Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to coinex v2 #2338

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Migrate to coinex v2 #2338

merged 1 commit into from
Dec 12, 2024

Conversation

nick-bisonai
Copy link
Collaborator

Description

v1 endpoint to v2 endpoint
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Dec 12, 2024
@nick-bisonai nick-bisonai requested a review from a team as a code owner December 12, 2024 09:12
Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes in this pull request enhance the CoinexFetcher functionality within the coinex package. Key modifications include the introduction of JSON handling, restructuring of data types for subscriptions, and the addition of a new method for reading WebSocket data. The Subscription struct now utilizes a more organized SubscribeParams type, and a new State type is introduced to represent market data. Additionally, the Response type has been updated to align with these changes, streamlining the data handling process.

Changes

File Path Change Summary
node/pkg/websocketfetcher/providers/coinex/coinex.go - Added method customReadFunc to CoinexFetcher for specialized WebSocket data reading and error handling.
- Updated Run method to utilize customReadFunc.
node/pkg/websocketfetcher/providers/coinex/type.go - Updated URL constant for WebSocket endpoint.
- Introduced SubscribeParams type for structured subscription parameters.
- Modified Subscription type to use SubscribeParams.
- Added State type for market data representation.
- Replaced Ticker type with Data, which includes StateList.
- Updated Response type to include new Data type.
node/pkg/websocketfetcher/providers/coinex/utils.go - Simplified ResponseToFeedDataList function by iterating directly over data.Data.StateList, removing nested loops while retaining existing logic for feed existence checks and error handling.
node/pkg/websocketfetcher/tests/utils_test.go - Updated test cases in TestMessageToStructCoinex to reflect changes in JSON structure from flat params to nested data with state_list. Adjusted assertions accordingly.

Possibly related PRs

Suggested reviewers

  • Intizar-T

Poem

In the land of code where bunnies hop,
The CoinexFetcher now takes the top.
With structured data and webs that connect,
We read and we write, oh what a perfect effect!
So let’s celebrate with a joyful cheer,
For clearer paths in the code we hold dear! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 400576b and 9aff1de.

📒 Files selected for processing (4)
  • node/pkg/websocketfetcher/providers/coinex/coinex.go (3 hunks)
  • node/pkg/websocketfetcher/providers/coinex/type.go (1 hunks)
  • node/pkg/websocketfetcher/providers/coinex/utils.go (1 hunks)
  • node/pkg/websocketfetcher/tests/utils_test.go (2 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nick-bisonai nick-bisonai merged commit 28f78c5 into master Dec 12, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the fix/fix-coinex branch December 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant